Editable HighlightView Implementation #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make visible a editingcontroller & textspan getter
|
Seems good to me ! |
|
I've used @tusharsadhwani's branch in a small side project of mine, and it's working beautifully! It'd be good to get this merged. 👍 |
|
Since this project seems kinda abandoned, and since the subdirectory-based structure of this repo doesn't let you directly add a fork's github URL in your You can use my fork in your projects by doing this in your dependencies:
flutter:
sdk: flutter
highlight: ^0.6.0
flutter_highlight:
git: https://github.com/tusharsadhwani/flutter_highlight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on the implementation in PR #13
Adds a controller property to HighlightView, so people can provide text via text property or via controller property
Add an editable property, which if true, renders a TextField instead of a RichText
Updated the example to use editable HighlightView
Fixes #3
Fixes #6